Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get Tty from container to know adequate way to attach to #9348

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Apr 4, 2022

What I did
inspect container so we know if we need to attach with a TTY

Related issue
closes #9288

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@ndeloof ndeloof requested a review from glours April 4, 2022 09:41
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ng TTY

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours merged commit 8d815ff into docker:v2 Apr 4, 2022
@ndeloof ndeloof deleted the attach_tty branch April 4, 2022 12:46
khalwat added a commit to nystudio107/craft that referenced this pull request Apr 7, 2022
khalwat added a commit to nystudio107/devmode that referenced this pull request Apr 7, 2022
khalwat added a commit to nystudio107/plugindev that referenced this pull request Apr 7, 2022
khalwat added a commit to nystudio107/matrixfacades that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants