fix: prevent network name ambiguity #9520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NetworkInspect` will match a network ID by prefix. While rare, it's possible that users might use a network name that is also a valid network ID prefix for a pre-existing Docker network. (In the reported case, the network was named `db`, for example.) Fixes docker#9496. Signed-off-by: Milas Bowman <milas@tilt.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
NetworkInspectwill match a network ID by prefix. While rare,it's possible that users might use a network name that is also
a valid network ID prefix for a pre-existing Docker network.
(In the reported case, the network was named
db, for example.)Changed this to use
NetworkListwith a filter by name, so thatonly the exact network will be found (if it exists).
Related issue
Fixes #9496
(not mandatory) A picture of a cute animal, if possible in relation with what you did
