display creation warnings from the engine #9998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
display-engine-warnings
branch
from
d7e41f8
to
a077e8a
Compare
Codecov ReportBase: 75.86% // Head: 74.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #9998 +/- ##
==========================================
- Coverage 75.86% 74.56% -1.30%
==========================================
Files 2 2
Lines 232 232
==========================================
- Hits 176 173 -3
- Misses 49 51 +2
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
milas
approved these changes
Nov 15, 2022
laurazard
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
Display warnings send by the engine during the container creation
Related issue
fixes #8466 , in fact it doesn't fix the issue but will explain why the configuration isn't applied
(not mandatory) A picture of a cute animal, if possible in relation with what you did
