Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] fix and refactor static packages with fixed cross-comp on moby #718

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 6, 2022

follow-up #665 (comment)

this builds the docker engine from moby/moby#43529 which fixes issues with cross compilation to remove unneeded logic.

it also fixes cross comp for extra tools (containerd, runc, tini, etc...) which is currently not cover on master branch but fixed in moby/moby#43529.

see last commit

@crazy-max crazy-max force-pushed the fix-static-pkgs-next branch 2 times, most recently from 51f3856 to 80d7de6 Compare July 6, 2022 14:56
@crazy-max crazy-max force-pushed the fix-static-pkgs-next branch 6 times, most recently from 74cc4a5 to 43ae8e3 Compare July 20, 2022 07:55
@crazy-max
Copy link
Member Author

crazy-max commented Jul 20, 2022

https://ci-next.docker.com/public/blue/organizations/jenkins/docker-ce-packaging/detail/PR-718/10/pipeline/1259#step-1369-log-373

#63 [linux/arm/v6 all 1/1] COPY --link --from=release-all /out /
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa0ba90]

goroutine 26 [running]:
github.com/moby/buildkit/util/progress/progressui.(*textMux).print(0x4000687df8, 0x4000687e70)
	/go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui/printer.go:284 +0x590
github.com/moby/buildkit/util/progress/progressui.DisplaySolveStatus(0x1db83a0, 0x400023c140, 0x0, 0x0, 0x0, 0x0, 0x1d727a0, 0x4000010020, 0x4000134480, 0x0, ...)
	/go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/util/progress/progressui/display.go:83 +0x2b0
github.com/docker/buildx/util/progress.NewPrinter.func1(0x1a9fe45, 0x4, 0x400039e410, 0x1dc1f18, 0x4000010020, 0x1db83a0, 0x400023c140, 0x4000134480, 0x40005ec4b0, 0x40001344e0)
	/go/src/github.com/docker/buildx/util/progress/printer.go:99 +0xdc
created by github.com/docker/buildx/util/progress.NewPrinter
	/go/src/github.com/docker/buildx/util/progress/printer.go:87 +0x18c
make[1]: *** [Makefile:44: build] Error 2

looks like the jenkins nodes are using buildx 0.8.1, this should be fixed with buildx 0.8.2.

@thaJeztah can you update buildx on the nodes?

@crazy-max crazy-max force-pushed the fix-static-pkgs-next branch 2 times, most recently from d00ac43 to cab4ca2 Compare July 22, 2022 12:18
crazy-max and others added 13 commits July 25, 2022 03:24
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This splits the CLI, Engine, and containerd packages to allow downloading
the cli separate from the daemon, as well as (in future) allowing us to
do a containerd release without also requiring an engine release.

With this patch:

    make REF=v22.06.0-beta.0 VERSION=v22.06.0-beta.0 TARGETPLATFORM=linux/amd64 static

    static/build
    ├── bundles-ce-static-linux-x86_64.tar.gz
    └── linux
        └── amd64
            ├── containerd-1.6.4.tgz
            ├── docker-buildx-plugin-0.8.2.tgz
            ├── docker-cli-22.06.0-beta.0.tgz
            ├── docker-engine-22.06.0-beta.0.tgz
            ├── docker-compose-plugin-2.6.1.tgz
            ├── docker-rootless-extras-22.06.0-beta.0.tgz
            └── docker-scan-plugin-0.17.0.tgz

    2 directories, 8 files

    ls -lh static/build/linux/amd64/
    total 215208
    -rw-r--r--  1 sebastiaan  staff    31M Jun 29 00:21 containerd-1.6.4.tgz
    -rw-r--r--  1 sebastiaan  staff    14M Jun 29 00:21 docker-buildx-plugin-0.8.2.tgz
    -rw-r--r--  1 sebastiaan  staff   8.2M Jun 29 00:21 docker-cli-22.06.0-beta.0.tgz
    -rw-r--r--  1 sebastiaan  staff    19M Jun 29 00:21 docker-engine-22.06.0-beta.0.tgz
    -rw-r--r--  1 sebastiaan  staff   8.8M Jun 29 00:21 docker-compose-plugin-2.6.1.tgz
    -rw-r--r--  1 sebastiaan  staff    19M Jun 29 00:21 docker-rootless-extras-22.06.0-beta.0.tgz
    -rw-r--r--  1 sebastiaan  staff   4.4M Jun 29 00:21 docker-scan-plugin-0.17.0.tgz

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants