This repository was archived by the owner on Sep 12, 2018. It is now read-only.
Lock out setup_database method #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-
force-pushed
the
710_lockout_db_setup
branch
from
6a69b73 to
49a3e93
Compare
|
This looks good! The use of the filesystem my not have enough visibility to manage locking when multiple nodes are running upgrade. If this covers the common use case, this may not matter. |
|
Thanks a lot @shin- !!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that multiple gunicorn workers don't attempt to initialize DB at the same time
Fixes #710 !
@dmp42