Skip to content

Documentation: Remove reference to PUBLISH Dockerfile directive in networking docs #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

deployable
Copy link
Contributor

Proposed changes

Remove reference to PUBLISH Dockerfile directive in networking documentation as PUBLISH does not exist in the Dockerfile reference https://docs.docker.com/engine/reference/builder/

@johndmulhausen
Copy link
Contributor

Good catch. Just so there's a note about what's possible when using config files, I think we should talk about the EXPOSE directive in Dockerfiles here, which are probably what the original writer meant.

@thaJeztah
Copy link
Member

EXPOSE doesn't publish, so likely needs some extra words in that case

@mdlinville
Copy link

mdlinville commented Oct 10, 2017

EXPOSE seems pretty useless really. I've been de-emphasizing it. I did a light edit to make this a teensy bit more clear.

@mdlinville mdlinville merged commit ae4d35c into docker:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants