Skip to content

Conversation

corpsee
Copy link

@corpsee corpsee commented Oct 13, 2018

Proposed changes

I Add more information about Docker Engine/Compose versions to section about Compose file.

@GordonTheTurtle
Copy link

Deploy preview for docsdocker ready!

Built with commit 85b3565

https://deploy-preview-7506--docsdocker.netlify.com

@bermudezmt bermudezmt added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Dec 27, 2018
Copy link
Contributor

@shin- shin- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think old versions of docker-compose should be mentioned in the documentation, as we do not provide any support for them. All versions of the format mentioned in the docs are supported by the latest version of Compose.

- Removed: `volume_driver`, `volumes_from`, `cpu_shares`, `cpu_quota`,
`cpuset`, `mem_limit`, `memswap_limit`, `extends`, `group_add`. See
the [upgrading](#upgrading) guide for how to migrate away from these.
(For more information on `extends`, see [Extending services](/compose/extends.md#extending-services).)

- Added: [deploy](/compose/compose-file/index.md#deploy)

### Version 3.1

Version 3.1 files are supported by **Compose 1.11.0+** and require a Docker Engine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The and require a Docker Engine may be ambiguous; to use this version of the compose-file specification, you need either;

  • Docker Compose 1.11.0 (or higher)
  • Docker Engine 1.13.1 (or higher); if you want to use it for docker stack deploy

There may be restrictions to the engine version that is supported by each Docker Compose version though (for example, Docker Compose 1.17 requires Docker Engine 17.06 or up; https://github.com/docker/compose/blob/master/CHANGELOG.md#1170-2017-11-02)

@bermudezmt
Copy link
Contributor

@corpsee Thank you for your feedback! We have received and reviewed your changes. After a technical review, we have decided not to incorporate your suggested changes. If you have additional concerns, feel free to submit a new issue in this repository.

@bermudezmt bermudezmt closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants