Modify Network structures json tags #17536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aboch please use |
|
@tibor ok |
- So that they comply with docker inspect convention Which is allowing camel case for json field names Signed-off-by: Alessandro Boch <aboch@docker.com>
|
@tiborvass Addressed your comment. PTAL. Thanks. |
|
LGTM |
|
LGTM 😉 |
|
LGTM |
|
Tested this patch with compose. We need to make some small changes to the test suite, but no changes to the application code. LGTM |
tiborvass
added a commit
that referenced
this pull request
Oct 30, 2015
Modify Network structures json tags
|
After testing the change with Swarm, properties below /cc @dnephin @tiborvass |
|
@abronan thanks, that's weird :S |
|
Ping @moxiegirl for out-of-band docs check |
|
@tiborvass I'll check this and add any changes to #17340 |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tiborvass
pushed a commit
to tiborvass/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 286fe69) Conflicts: docs/reference/api/docker_remote_api_v1.22.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is allowing camel case for json field names
Fixes #17519
Signed-off-by: Alessandro Boch aboch@docker.com