Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate array in redirect_from directive #1705

Merged
merged 1 commit into from
Feb 17, 2017
Merged

remove duplicate array in redirect_from directive #1705

merged 1 commit into from
Feb 17, 2017

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Feb 15, 2017

This PR fixes a build failure I saw locally with the latest version of github-pages.

  Liquid Exception: undefined method `end_with?' for ["/cs-engine/release-notes/prior-release-notes/"]:Array in 404.md
  bundler: failed to load command: jekyll (/Users/parkr/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bin/jekyll)
  NoMethodError: undefined method `end_with?' for ["/cs-engine/release-notes/prior-release-notes/"]:Array

@johndmulhausen
Copy link

Goodness gracious, @parkr is opening a PR against our docs! Welcome, we are big fans of Jekyll around here. While I have you: Bump Rouge to 2.0! @jneen added Dockerfile lexer support! :)

Okay, the toc.yaml change looks great.

The problem with pinning to GH-Pages 121, however, is that we are using starefossen/github-pages to synchronize our Dockerfile's GH-Pages environment and the Gemfile's GH-Pages environment, and the latest versions-specific tag on that repo is 112:

If there's a better way to get Dockerized GitHub Pages then I'd love to use the latest, but I'm nervous of having the production environment (specified in the Dockerfile) lose sync with Gemfile we are using to author locally, set up staging on Netlify, etc.

Long story -- the TL;DR is would you mind backing out your Gemfile change?

@parkr
Copy link
Contributor Author

parkr commented Feb 16, 2017

Bump Rouge to 2.0! @jneen added Dockerfile lexer support! :)

Haha, we have it filed (jekyll/jekyll#5556) but we hit a bit of a compatibility roadblock under SemVer: jekyll/jekyll#5230 (comment)

we are using starefossen/github-pages to synchronize our Dockerfile's GH-Pages environment and the Gemfile's GH-Pages environment, and the latest versions-specific tag on that repo is 112

Perhaps we can work together to automatically release a new version whenever we push a new Release to github/pages-gem. I'll open an issue.

Long story -- the TL;DR is would you mind backing out your Gemfile change?

Happy to! I will remove the commit. 👍

…ase notes

Fixes the following error:

  Liquid Exception: undefined method `end_with?' for ["/cs-engine/release-notes/prior-release-notes/"]:Array in 404.md
bundler: failed to load command: jekyll (/Users/parkr/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bin/jekyll)
NoMethodError: undefined method `end_with?' for ["/cs-engine/release-notes/prior-release-notes/"]:Array
  /Users/parkr/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/jekyll-3.3.1/lib/jekyll/renderer.rb:202:in `permalink_ext'
@johndmulhausen
Copy link

@parkr I would love to work with you on Dockerizing GitHub Pages. We're pretty good at crafting Docker files here. ;)

@johndmulhausen johndmulhausen merged commit d427320 into docker:master Feb 17, 2017
@johndmulhausen
Copy link

@parkr Let me know when your issue is opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants