Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cache): gha backend timeout opt #19525

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Feb 28, 2024

Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com

Description

Adds a timeout opt for gha cache backend import/export.

Related issues or tickets

moby/buildkit#4702

Reviews

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Feb 28, 2024
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 68819e4
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65df56c2d88a560008b50570
😎 Deploy Preview https://deploy-preview-19525--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@dvdksn dvdksn merged commit fb58333 into docker:main Feb 28, 2024
9 checks passed
@dvdksn dvdksn deleted the gha-cache-timeout branch February 28, 2024 16:03
@crazy-max
Copy link
Member

@dvdksn I think we could add a callout in https://docs.docker.com/build/ci/github-actions/cache/#github-cache that says that timeout attribute can be increased in case of timeout linked to rate-limit when using mode=max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants