You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
When doing a streaming request we can end-up leaking connections to the docker daemon if there's no activity on the stream. A simple example of this is calling Client.ContainerLogs() with Follow:true and stopping. No new logs must be generated from that point on. While we do have access to http.Response.Body to close it, the connection will only close on the next write error.
This module would make cancellation fairly easy to integrate with the current code.
The text was updated successfully, but these errors were encountered:
mathpl
changed the title
Cancelation on streaming requests can lead to connection leak
Cancellation on streaming requests can lead to connection leak
Jan 6, 2016
I agree with you, it's a good feature to have for those requests that handle streams. We manage cancellations in the server already, so we should incorporate them in the client too.
When doing a streaming request we can end-up leaking connections to the docker daemon if there's no activity on the stream. A simple example of this is calling Client.ContainerLogs() with Follow:true and stopping. No new logs must be generated from that point on. While we do have access to http.Response.Body to close it, the connection will only close on the next write error.
This module would make cancellation fairly easy to integrate with the current code.
The text was updated successfully, but these errors were encountered: