Skip to content
This repository has been archived by the owner on Jun 11, 2021. It is now read-only.

Added ability to work with Hyper-v #1491

Closed
wants to merge 8 commits into from
Closed

Conversation

floradu88
Copy link

Provided that you run kitematic with administrator right you can use hyper-v with Kitematic.

Check developer-readme.txt for more information, because hyper-v needs to have a virtual switch in order for it to access the outside world.

Related to this issue:
#1463

@StefanScherer
Copy link
Member

This is a great aproach. I also think of Kitematic to be used for Windows Container Hosts (Windows Server 2016 TP4).

if (HypervBox.pathExists())
{
return hypervPath;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this function needs to return an exe file name, which is used below, to check the version

@floradu88
Copy link
Author

Will add the necessary bits soon.

@pmario
Copy link

pmario commented Mar 9, 2016

If you put your changes into a feature branch and not master, I could directly send pull requests to you. It would make testing easier too.

@floradu88
Copy link
Author

Created branch for the things above. https://github.com/floradu88/kitematic/tree/hyperv-support

@stebet
Copy link

stebet commented Mar 13, 2016

So glad to see this. Looking forward to seeing it in action :)

@FrenchBen
Copy link
Contributor

@floradu88 Can you make sure to sign your commits? This will make sure that it's in-line with our contribution guidelines:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md

@floradu88
Copy link
Author

@FrenchBen ok, will do so from now on.

@FrenchBen
Copy link
Contributor

Should this PR be closed in favor of #1541 ?

@floradu88
Copy link
Author

@FrenchBen It might be :)

@FrenchBen
Copy link
Contributor

Closing in favor of #1541

@FrenchBen FrenchBen closed this Apr 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants