-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Conversation
Added ability to work with Hyper-v
Merge latest changes to my fork
This is a great aproach. I also think of Kitematic to be used for Windows Container Hosts (Windows Server 2016 TP4). |
if (HypervBox.pathExists()) | ||
{ | ||
return hypervPath; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo this function needs to return an exe file name, which is used below, to check the version
Will add the necessary bits soon. |
If you put your changes into a feature branch and not master, I could directly send pull requests to you. It would make testing easier too. |
Created branch for the things above. https://github.com/floradu88/kitematic/tree/hyperv-support |
So glad to see this. Looking forward to seeing it in action :) |
@floradu88 Can you make sure to sign your commits? This will make sure that it's in-line with our contribution guidelines: |
@FrenchBen ok, will do so from now on. |
Should this PR be closed in favor of #1541 ? |
@FrenchBen It might be :) |
Closing in favor of #1541 |
Provided that you run kitematic with administrator right you can use hyper-v with Kitematic.
Check developer-readme.txt for more information, because hyper-v needs to have a virtual switch in order for it to access the outside world.
Related to this issue:
#1463