Do not return boltdb bucket not found error #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mrjana: Please also remove the variable definition for ErrBoltBucketNotFound. LGTM otherwise. |
While doing a boltdb operation and if the bucket is not found we should not return a boltdb specific bucket not found error because this causes leaky abstraction where in the user of libkv needs to know about boltdb and import boltdb dependencies neither of which is desirable. Replaced all the bucket not found errors with the more generic `store.ErrKeyNotFound` error which is more appropriate. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
|
@sanimej Removed and updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing a boltdb operation and if the bucket is not found
we should not return a boltdb specific bucket not found error
because this causes leaky abstraction where in the user of libkv
needs to know about boltdb and import boltdb dependencies
neither of which is desirable. Replaced all the bucket not found
errors with the more generic
store.ErrKeyNotFounderror whichis more appropriate.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com