Network db stabilization #1860
Merged
Network db stabilization #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcrisciani
force-pushed
the
network-db-stabilization
branch
4 times, most recently
from
61d3c66 to
ece0dea
Compare
mavenugo
reviewed
Aug 1, 2017
networkdb/networkdb.go
Outdated
| @@ -436,8 +436,7 @@ func (nDB *NetworkDB) deleteNetworkEntriesForNode(deletedNode string) { | |||
| nDB.Unlock() | |||
| } | |||
|
|
|||
| func (nDB *NetworkDB) deleteNodeNetworkEntries(nid, node string) { | |||
| nDB.Lock() | |||
| func (nDB *NetworkDB) deleteNodeNetworkEntries(nid, node string, flush bool) { | |||
There was a problem hiding this comment.
The logic is very complicated depending on the case that is being handled by this function.
Can you please document this function clearly on which cases are addressed by each block ?
Also, the name flush is a bit misleading. Consider renaming it ?
There was a problem hiding this comment.
Also do we need the flush flag ?
If it is used to identify self, cant we simply check for node == nDB.config.NodeName ?
- Introduced back the Invalidate - optimized the rebroadcast logic Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
fcrisciani
force-pushed
the
network-db-stabilization
branch
from
ece0dea to
1faa602
Compare
mavenugo
reviewed
Aug 1, 2017
| // of the entries to be deleted. | ||
| // B) if the entry is owned by a remote node, then we can safely delete it. This | ||
| // ensures that if we join back this network as we receive the CREATE event for | ||
| // entries owned by remote nodes, we will accept them and we notify the application |
mavenugo
approved these changes
Aug 1, 2017
added 2 commits
August 1, 2017 14:08
join/leave fixes: - when a node leaves the network will deletes all the other nodes entries but will keep track of its to make sure that other nodes if they are tcp syncing will be aware of them being deleted. (a node that did not yet receive the network leave will potentially tcp/sync) add network reapTime, was not being set locally Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Before when a node was failing, all the nodes would bump the lamport time of all their entries. This means that if a node flap, there will be a storm of update of all the entries. This commit on the base of the previous logic guarantees that only the node that joins back will readvertise its own entries, the other nodes won't need to advertise again. Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
fcrisciani
force-pushed
the
network-db-stabilization
branch
from
1faa602 to
26db0b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes aimed to optimize and strengthen the networkDB component