-
Notifications
You must be signed in to change notification settings - Fork 2k
Add shared folder and virtualization check for Linux. #2122
Conversation
Fixes docker#2110 Signed-off-by: Emmanuel Bretelle <chantr4@gmail.com>
<3 |
LGTM. ping @jeanlaurent |
@chantra Sounds like the VT-X detection by checking for Note that I tested the Ca you make the necessary change to the code to detect amd virtualization flag ? [1]
|
Hi Jean-Laurent,
Yeah `lspcu` may not be available on every host so I would not rely on it.
When you mentioned you tested the `/proc/cpuinfo` trick to no avail on 3
hosts, was it because it did not check for `smd` flag?
If not. Can you gist the output of /proc/cpuinfo?
Also alternatively I wonder if /sys would expose the feature in some more
uniform way.
|
Yeah my bad this wasn't clear. Here are the cpuinfo of the 3 machines, two of which are running docker with no issue.
A low-end box, not running docker. But should be...
A google cloud instance, running docker flawlessly
|
So the issue is not that you cannot run docker, it is that if virtualization cpu flags are not enabled, it will make running docker in a VM dead slow. This is being handled in |
The shared folder bit looks good. I'm not sure if checking EDIT: At the very least I think I'd prefer to |
Use ioutil and also check for smd flag Signed-off-by: Emmanuel Bretelle <chantr4@gmail.com>
thx @chantra for adding the smd detection LGTM |
LGTM |
Add shared folder and virtualization check for Linux.
Fixes #2110