This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Increase heartbeat interval and timeout #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
|
LGTM |
dgageot
added a commit
that referenced
this pull request
Dec 21, 2015
…vals Increase heartbeat interval and timeout
This was referenced Dec 28, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abronan suggested the current timeout is very aggressive and I'm inclined to agree. This may help us with some of the issues we're seeing with RPC since it eases up a bit on the server. If it seems to be too long, we can revert.
cc @docker/machine-maintainers
Signed-off-by: Nathan LeClaire nathan.leclaire@gmail.com