This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Return error of command exec in SSH NativeClient #4550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously SSH NativeClient grasp error about session.Wait(), session.Run() and always return nil indicating succeeded even if command execution on the destination was failed.
But the error of session.Wait, Run is that definitely we need to feedback to user. so this PR changed the code to return error if session.Wait, Run failed in Shell func which is used by
docker-machine ssh
.Related issue(s)
#4549