Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Return error of command exec in SSH NativeClient #4550

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

ukinau
Copy link
Contributor

@ukinau ukinau commented Aug 3, 2018

Description

Previously SSH NativeClient grasp error about session.Wait(), session.Run() and always return nil indicating succeeded even if command execution on the destination was failed.
But the error of session.Wait, Run is that definitely we need to feedback to user. so this PR changed the code to return error if session.Wait, Run failed in Shell func which is used by docker-machine ssh.

Related issue(s)

#4549

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix-#4549" git@github.com:ukinau/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Yuki Nishiwaki <uckey.1067@gmail.com>
@shin-
Copy link
Contributor

shin- commented Sep 19, 2018

LGTM, thank you!

@shin- shin- merged commit 6c90ba4 into docker:master Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants