-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go #128
Bump go #128
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we only bumped credential-helpers
to 1.20.3?
Yeah this is still 1.20.3 on def branch: https://github.com/docker/docker-credential-helpers/blob/da93839996460f358368e183cbd8da06feae3fec/Dockerfile#L3 |
@crazy-max I added @neersighted as collaborator on this repo ("maintainer" access). We should probably look at creating a "packagers" or "release" team that we can use to give access to the (etoomany) repositories we have related to that now. (perhaps we need separate teams for the internal (private) and external repos though) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well 👍
I think we should be good updating it to 1.20.4 in this repo though (other repo should be updated as well; let me open a PR for that) |
I'm not sure we need separate teams, as to join a team you have to be part of the org (I think); thus any external (non-Docker Inc.) collaborators need to be non-team members. Maybe I'm wrong on that, through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on cred-helper update to 1.20.4
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.