-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI plugins: look for executables in PATH #328
Comments
Hi @imjasonh, thanks for the feedback! We intend for CLI plugins to be used internally at Docker to break up feature development and releases. We may reevaluate this in the future and build a management system. Our concern with doing so is that the current mechanism does not promote UX consistency and there's a risk that if we don't get it right, we'll confuse our users. For those outside Docker, we think there are two paths forward (for now):
|
Thanks for your response, and that sounds totally reasonable. That also explains why the docs for CLI plugins are uhhh... hard to find. 😄
In my particular case, I'm interested in integrating container image signing using cosign, which is captured here: #269 and prototyped as very simple CLI plugins here: https://github.com/imjasonh/cosign-docker-cli-plugins (it's already implemented as a standalone tool: https://github.com/sigstore/cosign) If there's real interest in having these integrated into the |
Also docker/cli#3283 |
I think @justincormack's take on docker/cli#3283 is right. We need to rethink the UX of signing and signature enforcement in the CLI. The all or nothing approach (irrespective of the signing system used) doesn't give users a good path forward. |
Tell us about your request
Today, docker CLI plugins must be executables at
~/.docker/cli-plugins/
named likedocker-foo
(invoked asdocker foo
)Requiring that these executables be found at only and exactly the path
~/.docker/cli-plugins/
can make them harder to install. For example, you can't easilygo install
into that directory.Instead, it might be simpler if the CLI plugin lookup logic additionally searched for
docker-foo
executables in thePATH
as a fallback.Which service(s) is this request for?
The
docker
CLITell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
I'm trying to simplify installation of docker CLI plugins.
Are you currently working around the issue?
Install instructions in READMEs or
install.sh
scripts that download/build and correctly place the executable in~/.docker/cli-plugins
.Additional context
As precedent, credential helpers already look in the configured
PATH
for executables matchingdocker-credential-*
matching the configuredcredHelpers
map value.There may be some overlap with #121
The text was updated successfully, but these errors were encountered: