scheduler: Clean up addOrUpdateNode #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…later Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
This function previously could take an uninitialized NodeInfo structure and fill in whatever was missing. This is very error-prone, so remove this logic and change the only caller that relies on it to always pass in a properly initialized NodeInfo. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2268 +/- ##
==========================================
+ Coverage 60.42% 60.45% +0.02%
==========================================
Files 125 125
Lines 20396 20394 -2
==========================================
+ Hits 12325 12329 +4
+ Misses 6679 6672 -7
- Partials 1392 1393 +1 |
Closed
|
LGTM |
6 tasks
tiborvass
pushed a commit
to tiborvass/docker-ce
that referenced
this pull request
Jun 20, 2017
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Feb 3, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 10, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 23, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function previously could take an uninitialized
NodeInfostructure and fill in whatever was missing. This is very error-prone, so remove this logic and change the only caller that relies on it to always pass in a properly initializedNodeInfo.This was originally a cleanup that was part of #2253, but it turns out to fix a bad panic. Opening as a separate PR for backport.
cc @andrewhsu