Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port in README.md #6

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Fix port in README.md #6

merged 1 commit into from
Nov 26, 2021

Conversation

felipecruz91
Copy link
Contributor

@felipecruz91 felipecruz91 commented Nov 26, 2021 •
edited
Loading

@glours When creating a dev env from this repo the compose file used is .docker/docker-compose.yaml and not the one at the root of the directory. Therefore we need to update the README.md accordingly to update the proxy port to 8080 instead of 80.

curl localhost:8080
["Blog post #0","Blog post #1","Blog post #2","Blog post #3","Blog post #4"]

glours
glours approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit f0ff602 into dockersamples:main Nov 26, 2021
@felipecruz91 felipecruz91 deleted the fix-port-readme branch November 26, 2021 11:22
@mkillianey mkillianey mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipecruz91 @glours