Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use new credential witness #272

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: use new credential witness #272

merged 1 commit into from
Jun 25, 2024

Conversation

Jayteekay
Copy link
Contributor

No description provided.

mike-parkhill
mike-parkhill reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@mike-parkhill mike-parkhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we integration test this at all?

@Jayteekay
Copy link
Contributor Author

can we integration test this at all?

We already have one but it's commented out because certs implementation is not merged yet, so it would fail.

@mike-parkhill
Copy link
Contributor

it's commented out because certs implementation is not merged yet, so it would fail.

can we add a comment to the Certs ticket to remind us to come back to un-comment that test?

@maycon-mello maycon-mello self-requested a review June 25, 2024 16:47
@maycon-mello maycon-mello merged commit d9fa824 into master Jun 25, 2024
1 of 3 checks passed
@maycon-mello maycon-mello deleted the bbs-revocation-fix branch June 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-parkhill mike-parkhill mike-parkhill left review comments

@maycon-mello maycon-mello maycon-mello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jayteekay @mike-parkhill @maycon-mello