Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2

Closed
wants to merge 2 commits into from

Conversation

sergei-bondarenko
Copy link

@sergei-bondarenko sergei-bondarenko commented Jun 10, 2018

Unzipping (I tried both UnZip 6.00 of 20 April 2009, by Info-ZIP. Maintained by C. Spieler and UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP) gives you preprocess-master directory instead of just preprocess.
Also python setup.py install is not worked for me (you can try it for yourself at https://colab.research.google.com/), it did not place the package in the right place so it can not be imported (honestly, I am lazy to find where it must be placed and why it's not working, because I tried pip and it works like a charm).

@@ -162,8 +162,7 @@ Download the latest `preprocess` zip source package, unzip it, and run `python
setup.py install`:
```
unzip master.zip
cd preprocess
python setup.py install
pip install preprocess-master/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to simply do it all in one command:

pip install https://github.com/doconce/preprocess/archive/master.zip

The text would also need to be updated.

KGHustad added a commit that referenced this pull request Jun 11, 2018
@KGHustad KGHustad closed this Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants