Update Tests Project to Compile with Dotnet Build #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwillspeak
force-pushed
the
build-fixlings
branch
2 times, most recently
from
eaf243f
to
7fb41bd
Compare
|
I'm happy with this build now. Am I good to squash and merge it @voieducode ? |
|
Good for me, I will publish to nuget once you're done. Might just have to
bump up the package version.
…On Fri, 21 Sep 2018, 11:17 Will Speak, ***@***.***> wrote:
I'm happy with this build now. Am I good to squash and merge it
@voieducode <https://github.com/voieducode> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA9AMP5FkXykAjPZaSQ6df_dJ9v2FCbxks5udLytgaJpZM4WvsFn>
.
|
iwillspeak
force-pushed
the
build-fixlings
branch
3 times, most recently
from
65b53fd
to
d56bed4
Compare
|
Squashed and version bumped. |
Makes the tests runnable with `dotnet test` and updates the packaging to use the new `dotnet pack` format so that metadata is read directly from the csproj. This means that a `nuspec` file is no longer needed and project reference metadata can't get out of sync with the actual build. * Update Tests Project to Compile with Dotnet Build. This means that the tests can now be run with `$ dotnet test`. * Update the pack to use the `.csproj`. This should reduce the duplication of metadata.
Update the version from `0.6.1.9` to `0.6.1.10`.
iwillspeak
force-pushed
the
build-fixlings
branch
from
d56bed4
to
19dace8
Compare
|
Thanks for the contribution, nuget package uploaded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the tests can now be run with
$ dotnet test.From a clean checkout, with the dotnet SDK 2.1.4xx I run:
To generate the package you can either pack with
dotnet($ dotnet pack src/Docopt) or use the existing nuget file ($ nuget pack src/NuGet/docopt.net.nuspec)