Use site title in page titles #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knownasilya
changed the title
For example my site is called "Ilya's Docs" and I have a section called "API". The full title will be "API - Ilya's Docs", unless the section is the same name as the title.
knownasilya
force-pushed
the
base-title
branch
from
4f141dc
to
75b0ae2
Compare
added 2 commits
August 26, 2016 16:32
Without the root title for next/prev titles
knownasilya
pushed a commit
to docpress/docpress-base
that referenced
this pull request
Aug 26, 2016
Goes with the changes over at docpress/docpress-core#107 so don't merge unless that PR is merged.
|
Thanks for your contribution! :♥ |
|
Shouldn't section title be page title? "section title" feels like it's the title for the whole section |
|
Agreed. Will make the change. |
knownasilya
pushed a commit
that referenced
this pull request
Aug 29, 2016
knownasilya
pushed a commit
that referenced
this pull request
Aug 29, 2016
|
Resolved in #109 |
knownasilya
pushed a commit
to docpress/docpress-base
that referenced
this pull request
Aug 29, 2016
* Use sectionTitle for prev/next titles Goes with the changes over at docpress/docpress-core#107 so don't merge unless that PR is merged. * Rename section title to pageTitle See #109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example my site is called "Ilya's Docs" and I have a section called
"API". The full title will be "API - Ilya's Docs", unless the section is the
same name as the title.
This gives subsections more of a context when open in a tab.
TODO
Ready for merge.