-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[temp]Infra/aws deploy #104
Draft
janaka
wants to merge
39
commits into
main
Choose a base branch
from
infra/aws-deploy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: dockerfile. switch base image from alpine to slim-buster. Plus some other tweaks - fix: poe task in pyproject.toml
secrets set as env vars will override values in a secrets.toml. secrets.toml is only checked if an env var isn't present.
Check if the folder configured exists if not attempt to create it. Call _config_logging() first so we so it applies in all following calls.
fix: the follow error that was being thrown on startup raise TypeError("Instance and class checks can only be used with" TypeError: Instance and class checks can only be used with @runtime_checkable protocols ref: run-llama/llama_index#3858
date format function was causing crash app still depends on source/web module. So re include in container build.
- fix: dockerfile. switch base image from alpine to slim-buster. Plus some other tweaks - fix: poe task in pyproject.toml
secrets set as env vars will override values in a secrets.toml. secrets.toml is only checked if an env var isn't present.
Check if the folder configured exists if not attempt to create it. Call _config_logging() first so we so it applies in all following calls.
fix: the follow error that was being thrown on startup raise TypeError("Instance and class checks can only be used with" TypeError: Instance and class checks can only be used with @runtime_checkable protocols ref: run-llama/llama_index#3858
date format function was causing crash app still depends on source/web module. So re include in container build.
…fix/dockerfile
duplicated, following rebase. handled elsewhere
from "prod" to "test"
it's not needed. Streamlit autobinds secrets.toml to env vars if the file is present.
avoid clash with python gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, e.g. what the new feature # is and/or what bug # it fixes. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes/Implements #(issue/feature)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.
Test Configuration:
Please describe the test setup. List them below as bullet points.
Checklist: