Fix build with GCC 11 #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 11 started warning about unused-but-set variables. Here's how it
fails:
examples/all_features/stringification.cpp: In function ‘void _DOCTEST_ANON_FUNC_20()’:
examples/all_features/stringification.cpp:106:26: error: variable ‘bla2’ set but not used [-Werror=unused-but-set-variable]
106 | MyTypeInherited<int> bla2;
| ^~~~
I don't think that that assignment is actually doing anything; in fact,
there's that other variable which is assigned in a similar manner, but
that one is also used for an assert.
|
A gentle ping to see if I can get this one merged. |
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Sep 13, 2021
Apply patch in order to fix gcc-11 related compilation error. The patch follows proposed fixes to upstream [1,2]. [1] doctest/doctest#505 [2] doctest/doctest#520 Closes: https://bugs.gentoo.org/812077 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Sep 18, 2021
Apply patch in order to fix gcc-11 related compilation error. The patch follows proposed fixes to upstream [1,2]. [1] doctest/doctest#505 [2] doctest/doctest#520 Closes: https://bugs.gentoo.org/812077 Signed-off-by: Petr Vaněk <arkamar@atlas.cz> Closes: #22280 Signed-off-by: Sam James <sam@gentoo.org>
onqtam
pushed a commit
that referenced
this pull request
Dec 10, 2021
GCC 11 started warning about unused-but-set variables. Here's how it
fails:
examples/all_features/stringification.cpp: In function ‘void _DOCTEST_ANON_FUNC_20()’:
examples/all_features/stringification.cpp:106:26: error: variable ‘bla2’ set but not used [-Werror=unused-but-set-variable]
106 | MyTypeInherited<int> bla2;
| ^~~~
I don't think that that assignment is actually doing anything; in fact,
there's that other variable which is assigned in a similar manner, but
that one is also used for an assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 11 started warning about unused-but-set variables. Here's how it
fails:
I don't think that that assignment is actually doing anything; in fact,
there's that other variable which is assigned in a similar manner, but
that one is also used for an assert.