Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Prevent to expose dead callbacks for nested #15

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Prevent to expose dead callbacks for nested #15

merged 1 commit into from
Mar 29, 2023

Conversation

pimpin
Copy link
Member

@pimpin pimpin commented Mar 15, 2023 •
edited
Loading

Nested documents do not have save method, then all commit related callbacks would never be called for them.
Let's remove them.

https://app.asana.com/0/1203552334223822/1204101687052473/f

@pimpin pimpin marked this pull request as ready for review March 15, 2023 14:14
@pimpin pimpin requested review from simkim, DamienVoreiter and a team March 15, 2023 14:32
simkim
simkim approved these changes Mar 15, 2023
View reviewed changes
Copy link

@simkim simkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it breaks no test, it's approved. I think I came to the same conclusion.

@pimpin pimpin merged commit 12500dc into master Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simkim simkim simkim approved these changes

@DamienVoreiter DamienVoreiter DamienVoreiter approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pimpin @simkim @DamienVoreiter