Add contains/2 to Gyx.Core.Spaces
#40
Conversation
|
Implementation for |
lib/core/spaces/protocols.ex
Outdated
| alias Gyx.Core.Spaces.{Discrete, Box} | ||
|
|
||
| @type space :: Discrete.t() | Box.t() | ||
| @type discete_point :: integer() |
There was a problem hiding this comment.
minor typo: discete_point -> discrete_point
| @@ -0,0 +1,16 @@ | |||
| defmodule Gyx.Core.Spaces.Tuple do | |||
There was a problem hiding this comment.
what about something like Gyx.Core.Spaces.List or Vector? to imply that any number of items is possible
There was a problem hiding this comment.
I think these are important decisions. How to name such module, and what data structure use for such implementation.
The motivation for using Tuple as naming is that it follows the convention on Gym.
In fact, it represents a fixed size, fixed position structure. Any space is always fixed for a particular environment (its action and observation spaces do not change), but they can differ widely among different environments.
The motivation for NOT using an actual tuple as data structure, is that it is not possible to type spec the elements to be a space :: Gyx.Core.Spaces.Box | Gyx.Core.Spaces.Discrete
And it might be unnatural to construct a tuple structure from parsing a Gym Tuple __repr__ (see Gyx.Gym.Utils where this case must be handled).
That's why I vote to name it Tuple, having the key spaces holding a list.
No description provided.