Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire a middleware for logging #1429

Closed
derrabus opened this issue Nov 21, 2021 · 3 comments · Fixed by #1456
Closed

Wire a middleware for logging #1429

derrabus opened this issue Nov 21, 2021 · 3 comments · Fixed by #1456
Labels
Improvement Ready to work on

Comments

@derrabus
Copy link
Member

Follows doctrine/dbal#4967

The way we currently use to wire a logger is deprecated in DBAL 3.2 and has been removed in DBAL 4. We should instead wire the new middleware.
@derrabus derrabus mentioned this issue Nov 21, 2021
Merged
3 tasks
@nicolas-grekas nicolas-grekas mentioned this issue Nov 23, 2021
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue Nov 23, 2021
@nicolas-grekas
minor #44231 Skip deprecation coming from DBAL 3.2 (nicolas-grekas)
ee4d480 
This PR was merged into the 4.4 branch.

Discussion
----------

Skip deprecation coming from DBAL 3.2

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

While waiting for doctrine/DoctrineBundle#1429 and related

Commits
-------

647d501 Skip deprecation coming from DBAL 3.2
@stof stof mentioned this issue Nov 23, 2021
Closed
@derrabus derrabus mentioned this issue Nov 27, 2021
Closed
@stof stof mentioned this issue Dec 7, 2021
Closed
@arcanisgk

This comment has been minimized.

Sign in to view
@derrabus
Copy link
Member Author

I wonder how this goes; the update of the package in which version will it be corrected?

It will be corrected as soon as somebody corrects it.

@l-vo l-vo mentioned this issue Dec 29, 2021
Merged
@dmaicher
Copy link
Contributor

Done in #1456

@r-martins r-martins mentioned this issue Mar 31, 2022
Closed
@Kodzila Kodzila mentioned this issue May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Ready to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to use dbal logging middleware instead of deprecated SQLLogger l-vo/DoctrineBundle
4 participants
@ostrolucky @dmaicher @arcanisgk @derrabus