Make it possible to auto map with multiple EMs #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2014
|
hi, i'm also working on this #321 |
|
ah doh. well lets hope some solution makes it in. note my solution might need some version checks to prevent issues when using older versions of symfony. |
|
@lsmith77 my solution seems simpler... and do not change the signature of protected methods (that can cause some bc breaks...). I will try to improve today |
| */ | ||
| protected function loadOrmEntityManager(array $entityManager, ContainerBuilder $container) | ||
| protected function loadOrmEntityManager(array $entityManager, ContainerBuilder $container, array $mappedBundles) |
There was a problem hiding this comment.
$mappedBundles should be optional for BC, shouldn't it?
There was a problem hiding this comment.
i made it optional inside symfony but didnt bother inside the bundle itself
|
👍 would be really great if this one or #321 would be accepted .-) thanks a lot! |
lsmith77
force-pushed
the
auto_map_with_many_em
branch
from
8c6f0aa
to
df14ad7
Compare
lsmith77
force-pushed
the
auto_map_with_many_em
branch
from
df14ad7
to
3379cb3
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 23, 2014
…ping feature (goetas) This PR was squashed before being merged into the 2.6-dev branch (closes #11815). Discussion ---------- Added some methods to improve the handling of auto_mapping feature | Q | A | ------------- | --- | Bug fix? |no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | doctrine/DoctrineBundle#60 | License | MIT This PR is a part that is required by: * doctrine/DoctrineMongoDBBundle#267 * doctrine/DoctrineBundle#321 The proposed PRs are an alternative to #11650 and doctrine/DoctrineBundle#322 Commits ------- 2e30a43 Added some methods to improve the handling of auto_mapping feature
fabpot
added a commit
to symfony/doctrine-bridge
that referenced
this pull request
Sep 23, 2014
…ping feature (goetas) This PR was squashed before being merged into the 2.6-dev branch (closes #11815). Discussion ---------- Added some methods to improve the handling of auto_mapping feature | Q | A | ------------- | --- | Bug fix? |no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | doctrine/DoctrineBundle#60 | License | MIT This PR is a part that is required by: * doctrine/DoctrineMongoDBBundle#267 * doctrine/DoctrineBundle#321 The proposed PRs are an alternative to symfony/symfony#11650 and doctrine/DoctrineBundle#322 Commits ------- 2e30a43 Added some methods to improve the handling of auto_mapping feature
|
closing in favor of #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also requires symfony/symfony#11650 fixes #60