update for new zend\hydrator component #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: Do you also want to rename DoctrineModule\Stdlib\Hydrator\DoctrineObject => DoctrineModule\Hydrator\DoctrineObject ? |
|
Needed to drop 5.4 support to get the tests running again. PHP 5.4 is also not support by PHP-Internals anymore. |
Not a good idea |
|
weird that the build succeeded. zend-mvc 2.6 required zend-hydrator 1.0, should be incompatible with 2.0. |
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
| chdir(dirname(__DIR__)); | |||
|
|
|||
| $loader = require_once('vendor/autoload.php'); | |||
| $loader = require ('vendor/autoload.php'); | |||
|
Closing since the pull request is rather old and the patch doesn't apply cleanly. I've checked whether the class in question is still used, which it isn't, so I also assume that this was cleaned up in the meantime. If not, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.