getManagerForClass should try to retrieve the default manager #374
Conversation
… of the first one found in the list
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DCOM-290 We use Jira to track the state of pull requests and the versions they got |
|
Could you also provide tests? |
|
The comprehension of the actual test was painful. Not great here (the test itself doesn't test a lot), but it covers the non regression of existing test. If you think something can be done better easily, I will try it but without a refactoring of the actual test, I think it will be hard. |
|
To abort the context of use, I have N managers for my entity, and I choose a default one. I supposed then that this method would return the default one, and not the first one declared. It may have a reason to this? |
|
I encounter the same problem as elernonelma. Do you have information about the pull request's validation, because it would really help ! |
This assumption seems wrong: the registry should map each entity to a separate manager. |
|
How can it be wrong? My entity must be used by N different databases, handled by N manager. |
|
Yes, but this class assumes that only one manager is used per type of class. The idea is to bridge different domains together via different ORM/ODM instances. |
|
Yes, it is exactly how it works and exactly what i expect it to. But I would expect that it would try to use the default manager first, instead of the first one found in the declaration. |
|
The "default" one is supposed to work as a fallback |
|
I dont expected it to work as a fallback, as it's default I expect it to works as a default. Did not find any information about it. Where did you see that? |
|
Hello, |
getManagerForClass should try to retrieve the default manager instead of the first one found in the list.