Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using ODM 2.x #351

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Allow using ODM 2.x #351

merged 2 commits into from
Aug 31, 2020

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Aug 31, 2020

See #349 (comment).

Suggesting this for a patch release as it involves no code changes and only loosens a require-dev constraint to allow testing against ODM 2.0.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builds only cover the mongodb-odm v2 constraint which makes this PR technically a drop of v1. But I think this is okay because this is a dev-dependency.

@greg0ire greg0ire merged commit dbde1e1 into doctrine:1.4.x Aug 31, 2020
@greg0ire
Copy link
Member

Thanks @alcaeus!

@alcaeus alcaeus deleted the odm-2.0 branch September 1, 2020 06:17
@greg0ire greg0ire added this to the 1.4.4 milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants