Reuse workflows #373
Merged
Reuse workflows #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
reuse-workflows
branch
2 times, most recently
from
f337f57
to
2f12c68
Compare
greg0ire
force-pushed
the
reuse-workflows
branch
from
2f12c68
to
51bdbd0
Compare
Looks like we are hitting vimeo/psalm#5570
| # https://github.com/doctrine/.github/issues/3 | ||
| - name: "Run PHP_CodeSniffer" | ||
| run: "vendor/bin/phpcs -q --no-colors --report=checkstyle | cs2pr" | ||
| uses: "doctrine/.github/.github/workflows/coding-standards.yml@1.1.1" |
There was a problem hiding this comment.
You're switching to PHP 8.0 and I don't see if this was done on purpose.
There was a problem hiding this comment.
It's on purpose, I don't think the version of PHP matters for phpcs
SenseException
approved these changes
Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.