DBAL-26: DateTime type column can't be nullable

[doctrinebot]

Jira issue originally created by user koubas:

After upgrade from B1 to B2 my app stopped working, throwing ConversionException on nullable DateTime field, value of which is null.
There is part of DateTimeType.php which causes it - if (!$val) matches even the valid null value.

public function convertToPHPValue($value, AbstractPlatform $platform)
{
    $val = ($value !== null)
        ? \DateTime::createFromFormat($platform->getDateTimeFormatString(), $value) : null;
    if (!$val) {
        throw ConversionException::conversionFailed($value, $this->getName());
    }
    return $val;
}

[doctrinebot]

Comment created by koubas:

maybe there should be a null check in _gatherRowData method, before the value is passed to convertToPHPValue of any type class

[doctrinebot]

Comment created by @beberlei:

This is a bug in the ConversionException code, sorry for that i will fix it tonight.

Btw, you are not using Beta2 but trunk, the ConversionException code was just committed yesterday. Additionally you should use the ORM with the Beta2 not with trunk of DBAL, they don't work together currently in some aspects (SchemaTool)

[doctrinebot]

Comment created by @beberlei:

This was introduced with DBAL-22 and is now fixed

[doctrinebot]

Issue was closed with resolution "Fixed"

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.