Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4645] Use error suppression instead of an error handler in MySQLi Connection #4647

Merged
merged 1 commit into from
May 13, 2021
Merged

[GH-4645] Use error suppression instead of an error handler in MySQLi Connection #4647

merged 1 commit into from
May 13, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented May 12, 2021 •
edited

Q A
Type bug
BC Break no

Closes #4645.

This is a backport of c9ce80a (#4081). It will also solve the test failure on non-Linux operating systems:

1) Doctrine\Tests\DBAL\Driver\Mysqli\MysqliConnectionTest::testRestoresErrorHandlerOnException
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Network is unreachable'
+'Permission denied'

tests/Doctrine/Tests/DBAL/Driver/Mysqli/MysqliConnectionTest.php:56

@morozov morozov added this to the 2.13.2 milestone May 12, 2021
@morozov morozov requested a review from greg0ire May 13, 2021 00:06
@morozov morozov merged commit 21f5eb5 into doctrine:2.13.x May 13, 2021
@morozov morozov deleted the issues/4645 branch May 13, 2021 19:59
@morozov morozov mentioned this pull request May 13, 2021
Closed
@morozov morozov linked an issue May 14, 2021 that may be closed by this pull request
PHP warning on unknown database with Doctrine DBAL 2.13.x #4645
Closed
@morozov morozov mentioned this pull request May 14, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Bug Connections Error Handling mysqli
Projects
None yet
Milestone
2.13.2
Development

Successfully merging this pull request may close these issues.

PHP warning on unknown database with Doctrine DBAL 2.13.x
3 participants
@morozov @Ocramius @greg0ire