Properly catch lowlevel MySQLi connection errors again #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a set_error_handler() callback returns "false", the PHP error handler will be involved. This is a regression since the previous version implicitly returned "null" and thus skipped the PHP error handler. See doctrine@26c7adc And doctrine@4a5be97
|
@morozov Yes, I can confirm that your fix solves my problem. So my interim fix here can be skipped. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restore the original error handling for MySQLi connections.
If a
set_error_handler()callback returnsfalse, the PHP error handler will be involved. This is a regression since the previous version implicitly returnednulland thus skipped the PHP error handler.See 26c7adc
And 4a5be97