Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4643] Fix SQLServerPlatform::quoteIdentifier() #4648

Merged
merged 1 commit into from
May 14, 2021
Merged

[GH-4643] Fix SQLServerPlatform::quoteIdentifier() #4648

merged 1 commit into from
May 14, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented May 13, 2021 •
edited

Q A
Type bug
BC Break no

Closes #4643.

From the Oracle documentation:

Quoted identifiers can contain any characters and punctuations marks as well as spaces. However, neither quoted nor nonquoted identifiers can contain double quotation marks or the null character (\0).

@morozov morozov linked an issue May 13, 2021 that may be closed by this pull request
SQLServer platform quoteIdentifier wrong escaping #4643
Closed
@morozov morozov added this to the 2.13.2 milestone May 13, 2021
@morozov morozov requested a review from greg0ire May 13, 2021 01:21
@morozov morozov marked this pull request as ready for review May 13, 2021 01:55
@morozov morozov requested a review from beberlei May 13, 2021 01:56
Ocramius
Ocramius previously approved these changes May 13, 2021
View reviewed changes
@greg0ire
Copy link
Member

greg0ire commented May 13, 2021 •
edited

Shouldn't the commit message (and PR title) reference 4643 (as opposed to 4645?)

@morozov morozov changed the title [GH-4645] Fix SQLServerPlatform::quoteIdentifier() [GH-4643] Fix SQLServerPlatform::quoteIdentifier() May 13, 2021
@morozov
Copy link
Member Author

morozov commented May 13, 2021

Shouldn't the commit message (and PR title) reference 4643 (as opposed to 4645?)

Yeah, they should. Thanks!

@morozov morozov merged commit 69ad868 into doctrine:2.13.x May 14, 2021
@morozov morozov deleted the issues/4643 branch May 14, 2021 19:53
@morozov morozov mentioned this pull request May 15, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@Ocramius Ocramius Ocramius left review comments

@beberlei beberlei Awaiting requested review from beberlei

Assignees
No one assigned
Labels
Bug Quoting SQL Server
Projects
None yet
Milestone
2.13.2
Development

Successfully merging this pull request may close these issues.

SQLServer platform quoteIdentifier wrong escaping
3 participants
@morozov @greg0ire @Ocramius