Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic rule for mass nouns ending in '-ware' #120

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Add generic rule for mass nouns ending in '-ware' #120

merged 3 commits into from
Feb 25, 2019

Conversation

benvdh
Copy link
Contributor

@benvdh benvdh commented Feb 19, 2019

Fixes #119 .

@benvdh benvdh changed the title Add special rule for 'hardware' Add generic rule for mass nouns ending in '-ware' Feb 19, 2019
@benvdh
Copy link
Contributor Author

benvdh commented Feb 19, 2019

@SenseException @garrettw I have replaced it with a regex now, and added some test cases. Given that the testcases pass, the rule must be working. However, Scrutinizer seems to disagree that the line is being hit by the tests. Any advice on what I need to do to make scrutinizer pass?

SenseException
SenseException approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a Scrutinizer thing, that went wrong. I guess your changes should be fine.

@benvdh
Copy link
Contributor Author

benvdh commented Feb 22, 2019

It seems to be a Scrutinizer thing, that went wrong. I guess your changes should be fine.

Thanks for the approval! Who will merge this? as I do not have write permissions to the repo...

@jwage jwage added this to the v2.0.0 milestone Feb 25, 2019
@jwage jwage self-assigned this Feb 25, 2019
@jwage jwage merged commit 2574369 into doctrine:master Feb 25, 2019
@jwage
Copy link
Member

jwage commented Feb 25, 2019

Thanks!

@obokaiwele obokaiwele mentioned this pull request Mar 31, 2020
Closed
@alcaeus alcaeus modified the milestones: 2.0.0, 1.4.0 May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettw garrettw garrettw left review comments

@SenseException SenseException SenseException approved these changes

@jwage jwage jwage approved these changes

Assignees

@jwage jwage

Labels
Enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Hardware is pluralized as hardwares
6 participants
@benvdh @jwage @garrettw @SenseException @alcaeus @benvdhgss