Italian basics Rules #197
Open
Italian basics Rules #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Italian language
insert const ITALIAN
malarzm
requested changes
May 5, 2022
There was a problem hiding this comment.
Grazie mille per il lavoro iniziale @riettotek! 🇮🇹
Apart from few comments I've left, the PR must meet our standards before merging:
- pass all the checks (the coding style can be fixed by running
vendor/bin/phpcbf) - have tests that prove your code is working as expected and preventing regressions in the future
| { | ||
| yield new Transformation(new Pattern('e$'), 'a'); | ||
| yield new Transformation(new Pattern('i$'), 'e'); | ||
| yield new Transformation(new Pattern('i$'), 'o'); |
There was a problem hiding this comment.
This transformation will never happen given the previous one has exactly same catch pattern
| yield new Transformation(new Pattern('a$'), 'e'); | ||
| yield new Transformation(new Pattern('e$'), 'i'); | ||
| yield new Transformation(new Pattern('io$'), 'i'); | ||
| yield new Transformation(new Pattern('o$'), 'i'); |
There was a problem hiding this comment.
These two rules could be merged into new Pattern('i?o$') I believe
| */ | ||
| public static function getIrregular() : iterable | ||
| { | ||
| return yield new Substitution(new Word(''), new Word('')); |
| @@ -0,0 +1,38 @@ | |||
| # doctrine-Italian-inflector- | |||
There was a problem hiding this comment.
This file seems irrelevant once we merge the PR
| { | ||
| yield from self::getDefault(); | ||
|
|
||
| yield new Pattern('.*ss'); |
There was a problem hiding this comment.
These words looks like copy-pasted from English
| yield new Pattern('equipment'); | ||
| yield new Pattern('evidence'); | ||
| yield new Pattern('feedback'); | ||
| yield new Pattern('food'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote the basics. I'm italian.
I'm already using these rules for migrations. If u want to include them by reviewing . Thank u :)