Refactor, more tests, for the recursive finder and finder in general #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor make sure that the same code is used to load the migrations whichever finder found them. The tests make sure that the name has to start with Version and cannot use something like CustomVersion but works for Version1_reset_versions for instance. Fix doctrine#276
mikeSimonson
force-pushed
the
finder-tests
branch
from
210dc30
to
556dc4a
Compare
mikeSimonson
added a commit
that referenced
this pull request
Jun 24, 2015
Refactor, more tests, for the recursive finder and finder in general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor make sure that the same code is used to load the migrations
whichever finder found them.
The tests make sure that the name has to start with Version and cannot
use something like CustomVersion but works for Version1_reset_versions
for instance. Fix #276