Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lookup::from() return type #1639

Closed
wants to merge 1 commit into from
Closed

Fix Lookup::from() return type #1639

wants to merge 1 commit into from

Conversation

olvlvl
Copy link
Contributor

@olvlvl olvlvl commented Sep 2, 2017

Hi,

This PR fixes Lookup::from() return type, which is either Lookup or BaseStage\Lookup. $this should be used when the same instance is returned, which is not the case here.

@alcaeus
Copy link
Member

alcaeus commented Sep 2, 2017

which is not the case here.

Why? The parent class returns $this as well, so the return type is correct: the same instance is returned.

@olvlvl
Copy link
Contributor Author

olvlvl commented Sep 2, 2017

You're right, it's the same instance.

@olvlvl olvlvl closed this Sep 2, 2017
@olvlvl olvlvl deleted the olvlvl-fix-return-type-2 branch September 2, 2017 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants