Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use platform options instead of deprecated custom options #10855

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Jul 25, 2023

DBAL's custom schema options have been deprecated in favor of platform options.

This patch uses the recommended method to prevent deprecations.

Closes #10854.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See doctrine/dbal#5476 for details.

According to the build, no need to bump the DBAL version, which makes sense when reading the pull request above: the platform options seem to have existed for a long time.

@derrabus derrabus added this to the 2.15.5 milestone Jul 25, 2023
@derrabus derrabus added the Bug label Jul 25, 2023
@derrabus derrabus merged commit db51ed4 into doctrine:2.15.x Jul 25, 2023
41 checks passed
@dunglas dunglas deleted the fix/use-platform-options branch July 25, 2023 16:32
derrabus added a commit that referenced this pull request Jul 28, 2023
* 2.15.x:
  Fix static analysis
  Other solution
  Avoid self deprecation
  fix: use platform options instead of deprecated custom options (#10855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants