Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support array-type arg in QB variadic calls #11242

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 9, 2024

Broke the behaviour in #8319 (see #8319 (comment))

Fixes #11241

@simPod simPod marked this pull request as ready for review February 9, 2024 13:18
@simPod
Copy link
Contributor Author

simPod commented Feb 9, 2024

cc @ondrejmirtes

@greg0ire greg0ire added the Bug label Feb 9, 2024
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the point of passing an array, but since this was an involuntary breaking change…

@ondrejmirtes
Copy link
Contributor

Not sure what's the point of passing an array,

It's one of the top examples in the docs :)

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Let's please deprecate this in 3.1.

@derrabus derrabus added this to the 3.0.1 milestone Feb 9, 2024
@derrabus derrabus merged commit 9acc70d into doctrine:3.0.x Feb 9, 2024
64 checks passed
@simPod simPod deleted the array branch February 9, 2024 14:32
derrabus added a commit to derrabus/orm that referenced this pull request Feb 21, 2024
* 3.0.x:
  Remove broken assertion from DateAddFunction and DateSubFunction (doctrine#11243)
  Remove unused trait
  [Documentation] Adding link to Postgres upgrade article (doctrine#11257)
  fix: support array-type arg in QB variadic calls (doctrine#11242)
derrabus added a commit to derrabus/orm that referenced this pull request Feb 21, 2024
* 3.1.x:
  Fix Static Analysis folder reference (doctrine#11281)
  Remove broken assertion from DateAddFunction and DateSubFunction (doctrine#11243)
  Account for inversedBy being a non-falsy-string or null
  Improve static analysis on AttachEntityListenersListener
  docs: recommend safer way to disable logging (doctrine#11269)
  Remove unused baseline entries
  Treat '0' as a legitimate trim char
  Add type field mapper documentation to the sidebar
  Mark document as orphan
  Use correction sectionauthor syntax
  Remove unused trait
  [Documentation] Adding link to Postgres upgrade article (doctrine#11257)
  Validate more variadic parameters (doctrine#11261)
  Throw if a variadic parameter contains unexpected named arguments (doctrine#11260)
  Make docs valid according to guides 0.3.3 (doctrine#11252)
  fix: support array-type arg in QB variadic calls (doctrine#11242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.0 - QueryBuilder - multi-select is not supported
4 participants