Throw a full-fledged exception on invalid call #11308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2.x, getAssociationMappedByTargetField() used to return null when called with the owning side of an association. That was undocumented and wrong because the phpdoc advertises a string as a return type. In 6ce0cf4, I wrongly assumed that nobody would be calling this method with the owning side of an association. Let us throw a full fledged exception and advertise the proper way of avoiding this situation. Closes doctrine#11250
SenseException
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.x,
getAssociationMappedByTargetField()used to returnnullwhen called with the owning side of an association.That was undocumented and wrong because the phpdoc advertises a string as a return type.
In #10723, I wrongly assumed that nobody would be calling this method with the owning side of an association.
Let us throw a full fledged exception and advertise the proper way of avoiding this situation.
Closes #11250