Deprecate the NotSupported exception #11470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to look into setting Psalm's |
greg0ire
approved these changes
May 22, 2024
derrabus
added a commit
that referenced
this pull request
May 22, 2024
* 3.2.x: Deprecate the NotSupported exception (#11470)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another thing we should've removed in 3.0. 🙈
All usages have been removed in the process of removing functionality relates to deprecated DBAL 2 and Persistence 2 features. We may chose to un-deprecate the class in the future, should we need it. But right now, we don't raise that exception anywhere, so we might as well remove it.