GH11551 - fix OneToManyPersister::deleteEntityCollection case where single-inheritence table parent entity is targetEntity. #11564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
single-inheritence entity parent as targetEntity. When using the parent entity for a single-inheritence table as the targetEntity for a property, the discriminator value should be all of the values in the discriminator map. OneToManyPersister::deleteEntityCollection has been amended to reflect this.
gitbugr
changed the title
greg0ire
reviewed
Aug 3, 2024
greg0ire
reviewed
Aug 3, 2024
| $em->persist($testEntityHolder); | ||
| $em->flush(); | ||
|
|
||
| $testEntityHolder->testEntities = new ArrayCollection(); |
There was a problem hiding this comment.
Here, you are only changing the inverse side of the relationship, right? With that in mind, and after reading this, I don't see why "All records should have been deleted". Am I missing something?
There was a problem hiding this comment.
Maybe.. unless I'm misunderstanding, I think that linked page is incomplete as it doesn't account for orphanRemoval. This suggests in that case the inverse side is not ignored?
There was a problem hiding this comment.
It looks like you're correct. Maybe that first page should be updated to account for that exception to the general rule?
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
greg0ire
approved these changes
Aug 3, 2024
SenseException
approved these changes
Aug 5, 2024
|
Thanks @gitbugr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11551
When using the parent entity for a single-inheritence table as the targetEntity for a property, the discriminator value should be all of the values in the discriminator map.
OneToManyPersister::deleteEntityCollection has been amended to reflect this.