Check for non-cacheable entities on metadata level, not at runtime #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3783 We use Jira to track the state of pull requests and the versions they got |
|
Any news /feedback on this? |
| * | ||
| * @return array | ||
| */ | ||
| public function getAssociationCacheDefaults ($fieldName, array $cache) |
There was a problem hiding this comment.
Extra space between the function name and open parenthesis
|
Besides minor CS fixes, looks good for me. Thanks @goetas |
|
done! thank you for reviewing my code |
|
This is gonna be in |
Ocramius
added a commit
that referenced
this pull request
Jul 16, 2015
Check for non-cacheable entities on metadata level, not at runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the check for non-cacheable entities from "runtime" to metadata definition.
If an entity has an association key as part of its PK, and this association key is not configured to be stored into SLC, an exception it thrown.
The previous approach was checking this constraint at "runtime" (right before saving the value), this PR moves this check at metadata level into (
_validateAndCompleteAssociationMappingmethod).testQueryNotCacheableAssociationExceptionther has been removed since this constraint is checked at metadata class loading time