Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docblock generation for nullable fields #6068

Closed
wants to merge 4 commits into from
Closed

Update docblock generation for nullable fields #6068

wants to merge 4 commits into from

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Oct 4, 2016 •
edited by Ocramius
Loading

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

TODO:

  • Add tests.

@Ocramius Ocramius added this to the 2.6.0 milestone Oct 27, 2016
@Ocramius Ocramius self-assigned this Nov 26, 2016
Ocramius added a commit that referenced this pull request Nov 26, 2016
@Ocramius
#6068 inlined code generating expression
3341781
Ocramius added a commit that referenced this pull request Nov 26, 2016
@Ocramius
#6068 simplified variable docblock codegen for nullable instance prop…
1d2baed 
…erties
Ocramius added a commit that referenced this pull request Nov 26, 2016
@Ocramius
#6068 corrected nullable field expression generator, made it private …
a4f76bd 
…to avoid misuse
Ocramius added a commit that referenced this pull request Nov 26, 2016
@Ocramius
#6068 hardened test logic to verify that nothing is present after the…
f8002ca 
… `|null` in `@var` and `@return` types
@Ocramius Ocramius closed this in 89a0086 Nov 26, 2016
@Ocramius
Copy link
Member

@phansys I've manually rebased and applied a few changes to the patch. Thanks!

89a0086

@Ocramius Ocramius changed the title [WIP] Update docblock generation for nullable fields Update docblock generation for nullable fields Nov 26, 2016
@phansys phansys deleted the entity_generator branch December 1, 2016 19:42
@phansys
Copy link
Contributor Author

phansys commented Dec 1, 2016

Thank you @Ocramius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Improvement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @Ocramius @lcobucci